Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update gffults & qc #69

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

hmkim
Copy link
Contributor

@hmkim hmkim commented Oct 24, 2023

(gffutils error & multiqc err) fixed

[multiqc]
Screenshot 2023-10-24 at 5 56 05 PM

gffutils

@dlaehnemann dlaehnemann changed the title update gffults & qc fix: update gffults & qc Oct 24, 2023
@dlaehnemann
Copy link
Contributor

Thanks for reporting this and tracking down the solution. I amended the pull request title to follow the conventional commit message syntax that we use for standardized and automated release drafting.

In addition, I quickly amended the indentation for the updated multiqc wrapper version specification. This was triggering a linting error. Let's hope tests pass and we can merge and release this quickl!

@dlaehnemann
Copy link
Contributor

This fixes #68.

@dlaehnemann
Copy link
Contributor

It seems like we are for some reason hitting a biomart cache race condition in the tests, now. So I am also updating the bioconductor-biomart package to its latest version and r-tidyverse to a newer version that uses the same r-base version. Let's hope this doesn't break tidyverse syntax usage (which would require further fixes)...

Copy link
Contributor

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all just version updates and the tests now all pass, so this should be good to go.

@dlaehnemann dlaehnemann merged commit 846693f into snakemake-workflows:master Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants